Skip to content

fix(agent): pass large Antigravity prompts on stdin and allow pwd - #1080

Open
shunkakinoki wants to merge 2 commits into
kenn-io:mainfrom
shunkakinoki:shunkakinoki/shun-1939-fix-roborev-antigravity-argv-overflow-and-pwd-permission
Open

fix(agent): pass large Antigravity prompts on stdin and allow pwd#1080
shunkakinoki wants to merge 2 commits into
kenn-io:mainfrom
shunkakinoki:shunkakinoki/shun-1939-fix-roborev-antigravity-argv-overflow-and-pwd-permission

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Aug 21, 2026

Copy link
Copy Markdown

Deliver Antigravity prompts that exceed the platform argv cap on stdin with no --prompt/--print/-p flag (agy >= 1.1.1 still reads non-TTY stdin when no prompt flag is present). Small prompts keep --prompt. Drop --sandbox for non-agentic print-mode reviews so pwd is not permission-gated. Reviews still do not get --dangerously-skip-permissions.

@shunkakinoki
fix(agent): pass large Antigravity prompts on stdin and allow pwd
ea2e489 
agy 1.1.1+ ignores stdin when a prompt flag is present, so oversized
reviews hit Linux MAX_ARG_STRLEN. Deliver those prompts on stdin with
no --prompt/--print/-p flag, and drop --sandbox so print-mode reviews
can run pwd without a yolo skip.
@roborev-ci

roborev-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

roborev: Combined Review (ea2e489)

Code changes require revision: one medium-severity sandboxing issue could allow background reviews to modify tracked files.

Medium

  • Background Antigravity reviews can mutate the real checkout — internal/agent/gemini.go:179
    Removing --sandbox runs non-agentic Antigravity reviews in the real checkout. Merely omitting --dangerously-skip-permissions does not guarantee read-only behavior because global Antigravity permissions may already authorize mutating tools or commands. Preserve sandboxing while narrowly allowing read-only probes such as pwd, or execute reviews in a disposable/read-only checkout.

Reviewers: 2 done | Synthesis: codex, 14s | Total: 3m16s

@shunkakinoki
fix(agent): grant agy review permissions and retry SQLITE_BUSY claims
aaea640 
Headless agy still exits 0 with empty output or fails wc/pwd unless
permissions.allow includes read_file(*) and inspect commands. Merge
those into the official settings.json without clobbering other keys.
Treat SQLITE_BUSY as transient in ClaimJob and stop error-logging
lock contention on the worker claim loop.
@roborev-ci

roborev-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

roborev: Combined Review (aaea640)

The PR needs changes: two medium-severity issues could crash the daemon and leave Antigravity’s security documentation inaccurate.

Medium

  • internal/agent/antigravity_settings.go:83 — A valid settings file containing JSON null unmarshals to a nil map. Assigning doc["permissions"] then panics and can crash the daemon. Reinitialize or reject a nil root map after unmarshalling, and add coverage for null.

  • internal/agent/gemini.go:182, docs/agents/index.md:183 — Reviews now omit --sandbox and automatically persist broad global permissions, but the documentation still promises sandbox confinement and suggests users can narrow a wildcard rule that subsequent reviews will restore. Document the automatic global merge, unsandboxed behavior, permission scope, and any opt-out.

Reviewers: 2 done | Synthesis: codex, 7s | Total: 5m34s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shunkakinoki